Skip to content

Conversation

MintsInc
Copy link
Member

@MintsInc MintsInc commented Sep 5, 2025

Context

This PR is the first step in a larger initiative to standardize CI workflows across all Datadog API client repositories. By converting our TypeScript testing workflow to a reusable workflow, we can:

  • Enable centralized CI management: The datadog-api-spec repo will be able to use
    the same testing workflow
  • Prepare for MergeQueue: Centralizing the CI in the datadog-api-spec repo is necessary to enable the MergeQueue

This PR serves as a proof-of-concept to validate that the reusable workflow approach works correctly before rolling it out to other client repositories and the specification repo.

This implementation follows the same pattern as the Go client changes in DataDog/datadog-api-client-go#3317.

Changes

New Files

  • .github/workflows/reusable-typescript-test.yml: A reusable workflow that contains the same logic as the original test workflow

Modified Files

  • .github/workflows/test.yml: Simplified to call the reusable workflow

Key Design Decisions

  • Behavior preservation: Every aspect of the original workflow is maintained through input parameters
  • Configurability: The reusable workflow accepts inputs for all major parameters (Node versions, platforms, test scripts)
  • Environment variables: Git author information is inherited from the caller workflow

Tests

This PR maintains identical CI behavior for this repository - same triggers, job matrix, conditional logic, and status reporting. After merging, we'll verify that the workflow is properly triggered on other PRs, then we'll test calling this reusable workflow from the datadog-api-spec repository to verify cross-repository execution and MergeQueue compatibility before rolling out to other client repositories.

@MintsInc MintsInc changed the title AAWF-562: Make TypeScript test workflow reusable Convert TypeScript testing workflow to reusable workflow Sep 5, 2025
@MintsInc MintsInc force-pushed the ulysse.mavrocordatos/AAWF-562/make-typescript-test-workflow-reusable branch from 605db6f to eca7dbb Compare September 5, 2025 14:46
@MintsInc MintsInc marked this pull request as ready for review September 5, 2025 14:50
@MintsInc MintsInc requested review from a team as code owners September 5, 2025 14:50
…ting, and filtering params (#2752)

Co-authored-by: ci.datadog-api-spec <[email protected]>
Co-authored-by: ci.datadog-api-spec <[email protected]>
Co-authored-by: Damien Fleurisson <[email protected]>
Co-authored-by: ci.datadog-api-spec <[email protected]>
@MintsInc MintsInc requested a review from a team as a code owner September 16, 2025 12:05
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 16, 2025
@MintsInc MintsInc marked this pull request as draft September 16, 2025 12:07
@MintsInc MintsInc closed this Sep 16, 2025
@MintsInc MintsInc deleted the ulysse.mavrocordatos/AAWF-562/make-typescript-test-workflow-reusable branch September 16, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants